Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: All the Client API work and dependencies rolled in to one monster PR #1139

Closed
wants to merge 62 commits into from
Closed

WIP: All the Client API work and dependencies rolled in to one monster PR #1139

wants to merge 62 commits into from

Conversation

endophage
Copy link
Contributor

@endophage endophage commented Apr 25, 2017 •
edited
Loading

This will track the overall state of merging the Client API and supercedes #1119

As other PRs get merged we will rebase this to reduce the size. We will also be looking to break down parts of this in to smaller PRs that can be independently reviewed and merged.

Replicated notes from #1119:

Huge feature list here and apologies for the PR bomb.

  • New Interface type defined for client interaction with a repository (client/interface.go)
  • GRPC implementation of the new interface (client_api/api/*)
  • CLI integration with GRPC API if configured (cmd/notary/repo_factory.go and other necessary knock on changes in the cmd/notary package)
  • JWT token auth for the GRPC API consistent with Notary Server and Docker Registry (auth/*). Some of this is to be upstreamed into docker/distribution when I get the chance.
    • If enabled "push" and "pull" actions will always be requested to guarantee the Client API can communicate with the upstream Notary Server to read repos and publish updates. The server configuration will also accept a map of GRPC Endpoint Name : [permissions] (documentation to be written) that allows users to arbitrarily configure in more permissions per GRPC API. Users would need their token server to issue those permissions as appropriate to their users.

Still needed:

  • more tests
  • documentation

Closes #557

David Lawrence and others added 30 commits March 20, 2017 13:59
add initial client api code
fa13191 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
adding client interface back in
90660e7 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
basic factory for local/remote client
3fac89b 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
clientapi works with cli
b024930 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
@endophage
grpc interceptors are working, need to get proper token auth in place
f2f3118 
Signed-off-by: David Lawrence <dclwrnc@gmail.com> (github: endophage)
regenerated certs for all the services and server side of tokens shou…
7760a77 
…ld be working

Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
grpc client needed GetGUN method to meet Repository interface
44656cc 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
fixing some interfaces
bc29fa6 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
server side of producing a token is working
2386ae0 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
working token auth end to end
cc73b50 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
@n4ss
Add Target operations to client API protobuf definitions and generate…
02415db 
…d code

Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
@n4ss
Add ChangeList operations to client API protobuf definitions
a0095e8 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
@n4ss
Add generated code for ChangeList grpc interface
904cf35 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
@n4ss
Add Init, Publish and returned Errors to client API gRPC interface
7bba7ec 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
@n4ss
Add Role operations to client API gRPC interface with generated code
9066aa3 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
@n4ss
Add remaining rpc definitions to client gRPC API interface
55ad281 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
@n4ss
Implement client api ListTargets
0da0e82 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
@n4ss
Implement more client api calls
8cd2776 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
@n4ss
Implement more client api calls - part 2
4d8d088 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
@n4ss
Implement more client api calls - part 3
6c0fd1e 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
@n4ss
Implement more client api calls - part 4
3c4ca95 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
@n4ss
Implement more client api calls - part 5
c5208b6 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
@n4ss
Finish implementing main part of client API endpoint
822b5e4 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
@n4ss
Switch Empty type to google protobuf's Empty type
1af5845 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
@n4ss
Add cryptoservice interface to client api endpoint
dd7c918 
Signed-off-by: David Lawrence <david.lawrence@docker.com>

Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com> (github: endophage)
@n4ss
Add missing response type and update generated files
1ad6d9d 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
@n4ss
Add client api prototypes to server interface
adca046 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
@n4ss
Fix cherry-pick conflicts
c63fb30 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
@n4ss
Add GUN parameters to client side of client api
270b9f3 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
@n4ss
Implement cient api server-side Init and Publish
158c945 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
David Lawrence and others added 27 commits March 20, 2017 14:08
use relative path for API CA in cmd/notary/config.json so it works fo…
e6e7e88 
…r everyone

Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
removing test that was intentionally failing. I was just using it to …
cdfd8df 
…exercise some of the code while I had a debugger running

Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
forward tokens from ClientAPI to notary server
bcc3abe 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
configure key storage for clientapi
297656c 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
wildcarded trustpinning for cert ids
1841e0c 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
update gorm to reduce size of #1110
894c960 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
addressing riyaz's review
7bceca2 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
@n4ss
Add export tuf command
64da591 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
@n4ss
Fix export command for delegations
fb3f1c3 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
@n4ss
Do not duplicate targets for delegations
475cb36 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
@n4ss
Create an Export cache to hook on notary repo caching
e0c59b9
@n4ss
Allow cache injection on top of configured notary repo
896913f 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
@n4ss
Refactor export cmd with a hook on the cache and add import through p…
f080c62 
…ublish

Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
@n4ss
Import hook on remote store's SetMulti rather than repo's Publish
b0b3c4d 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
@n4ss
Directly use HTTPStore as a remote to load the new metadata
1949bf1 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
making lint,vet,etc... pass
bc0f3f1 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
some cleanup of the export store
8583f60 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
making import super simple: "notary import gun role file"
62586ec 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
working basic version of add to file directly, no tests
2cc5c31 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)

add ability to sign with specific provided private keys. Still need to add CLI component, only underlying logic in place
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)

add ability to use signing keys from files on disk rather than key store
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)

adding tests
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)

adding a test for parseKeysCerts
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)

require an --output file for notary add(byhash) if an --input file is in use (and change --file to use the already standard -i/--input
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
generate any key and output it to a pair of .pub and .priv files
9ab801d 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
bugfixes
1d4737b 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
some refactoring and more bugfixes for client api
a8eac65 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
final fixes to work with prod
3972417 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
@n4ss
Move default locally/remotely managed role keys to a package local var
1c7b2e7 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
catalog tokens for cryptoservice operations
ace8293 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
fixing server managed snapshots for Client API
362c486 
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
include seperate configs and compose files for full local dev, and de…
791ceaf 
…v against prod notary server

Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
@endophage endophage mentioned this pull request Apr 25, 2017
Closed
@riyazdf riyazdf mentioned this pull request Sep 1, 2017
Merged
@endophage endophage closed this Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define an interface for the Notary repository
2 participants
@endophage @n4ss